London | 26-ITP-Jan | Alex Okorefe | Sprint 1 | Coursework#1010
Open
Alex-Os-Dev-Lab wants to merge 17 commits intoCodeYourFuture:mainfrom
Open
London | 26-ITP-Jan | Alex Okorefe | Sprint 1 | Coursework#1010Alex-Os-Dev-Lab wants to merge 17 commits intoCodeYourFuture:mainfrom
Alex-Os-Dev-Lab wants to merge 17 commits intoCodeYourFuture:mainfrom
Conversation
Utilized prettier to format code in (1-count.js; 2-initials.js; 3-paths.js)
…atement to fix error
…nd rationale of the program
Alex-Os-Dev-Lab
added
the
Needs Review
Alex-Os-Dev-Lab
force-pushed
the
coursework/sprint-1
branch
from
2ea8486 to
af47636
Compare
cjyuan
reviewed
Mar 2, 2026
cjyuan
added
Reviewed
Updated comments to clarify the range of random numbers generated.
Updated the comment to correct the number of function calls from 6 to 4; previously included method calls.
Contributor
|
Changes look good. Can you clarify the number of function+method calls in #1010 (comment) ? And if a PR is ready to be re-reviewed, you should also add the "Needs Review" label to it. |
Removed unnecessary padding for pence extraction.
Updated the comment to reflect the correct number of function calls and their locations.
Alex-Os-Dev-Lab
added
Needs Review
Contributor
|
LGTM. |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed the JavaScript tasks
Questions
No questions for now